add format_convert_file_Ver2 - #19
Open
rakagawa17 wants to merge 2 commits into
Open
Conversation
knakazawa99
reviewed
Apr 12, 2023
knakazawa99
left a comment
knakazawa99
left a comment
Owner
There was a problem hiding this comment.
【全体に対してのコメント】
- 命名は統一してほしい
- リスト構造を表すときに hogehoge_listにするか複数形にするかを揃えよう(今回であればアノテーションの中身が複数形になっているので、そちらに合わせるのが良いと思う。)
- 変数名を省略しない
- 省略しているところとしていないところがあるので、省略しない方でお願いします。
- 単数を表すものに複数形をつけない
- 意図が読めない変数名をつけない
- 番号等は意図が読み取れないので、明確な名前にしよう。
| @@ -0,0 +1,40 @@ | |||
| import json | |||
|
|
|||
| ANNOTATION_FILE = '/Users/ryotaroakagawa/PearOpenDataProject_Ver2/script/data/annotation.json' | |||
Owner
There was a problem hiding this comment.
これだと他の人が動かすときに書き換えないといけなくなるので、プロジェクトのディレクトリからのファイルパスにしよう！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New request because previous request closed with an error