[release-1.21] Move AggregationRuleTransform to shared common package to fix eventing RBAC race#2322
Open
knative-prow-robot wants to merge 1 commit into
Conversation
AggregationRuleTransform was only applied to KnativeServing but not to KnativeEventing. This caused the operator to continuously overwrite the rules of aggregated ClusterRoles (e.g. channelable-manipulator) with empty rules from the manifest, creating a race condition with the Kubernetes aggregation controller. During the race window, RBAC lookups against the aggregated role return 403 Forbidden. Move the transform from knativeserving/common to the shared reconciler/common package and apply it inside Transform(), so every component (Serving, Eventing, Kafka) benefits automatically. Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: knative-prow-robot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
size/M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.21 #2322 +/- ##
================================================
+ Coverage 63.45% 63.52% +0.07%
================================================
Files 49 49
Lines 1899 1900 +1
================================================
+ Hits 1205 1207 +2
+ Misses 600 599 -1
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2316