Skip to content

When shutting down the OTel providers have a ten second timeout.#3199

Merged
knative-prow[bot] merged 1 commit into
knative:mainfrom
dprotaso:otel-shutdown-timeout
Jun 30, 2025
Merged

When shutting down the OTel providers have a ten second timeout.#3199
knative-prow[bot] merged 1 commit into
knative:mainfrom
dprotaso:otel-shutdown-timeout

Conversation

@dprotaso
Copy link
Copy Markdown
Member

I noticed a misconfigured metrics URL would prevent the process
from quiting because it was trying to flush metrics forever.

I noticed a misconfigured metrics URL would prevent the process
from quiting because it was trying to flush metrics forever.
@knative-prow knative-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2025
@dprotaso
Copy link
Copy Markdown
Member Author

/assign @evankanderson @Cali0707

@knative-prow knative-prow Bot requested review from Leo6Leo and creydr June 30, 2025 16:46
@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (8481e7e) to head (9b8dbd6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3199      +/-   ##
==========================================
- Coverage   75.99%   75.96%   -0.03%     
==========================================
  Files         205      205              
  Lines       11709    11709              
==========================================
- Hits         8898     8895       -3     
- Misses       2541     2543       +2     
- Partials      270      271       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@evankanderson
Copy link
Copy Markdown
Member

/lgtm
/approve

I would even argue for a shorter shutdown (2-5s, and/or use a configurable timeout), but 10s seems plenty.

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot merged commit 434d221 into knative:main Jun 30, 2025
36 of 37 checks passed
@dprotaso dprotaso deleted the otel-shutdown-timeout branch June 30, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants