Skip to content

[observability] Default missing endpoint scheme to HTTPS#3200

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
dprotaso:better-url-handling
Jun 30, 2025
Merged

[observability] Default missing endpoint scheme to HTTPS#3200
knative-prow[bot] merged 2 commits into
knative:mainfrom
dprotaso:better-url-handling

Conversation

@dprotaso
Copy link
Copy Markdown
Member

@dprotaso dprotaso commented Jun 30, 2025

When testing prometheus endpoints I entered
some.domain.com:9090/some/path

And this took some.domain.com as the scheme. To avoid this landmine
if we end up with an opaque URL we prepend the 'https' scheme to
the endpoint

dprotaso added 2 commits June 30, 2025 13:38
When testing prometheus endpoints I entered
some.domain.com:9090/some/path

And this took `some.domain.com` as the scheme. To avoid this landmine
if we end up with an opaque URL we prepend the 'https' scheme to
the endpoint
@knative-prow knative-prow Bot requested review from creydr and skonto June 30, 2025 17:57
@knative-prow knative-prow Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 30, 2025
@dprotaso
Copy link
Copy Markdown
Member Author

/assign @Cali0707 @evankanderson

Copy link
Copy Markdown
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2025
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.04%. Comparing base (8481e7e) to head (a28da6e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
observability/metrics/provider.go 88.46% 1 Missing and 2 partials ⚠️
observability/tracing/provider.go 88.88% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3200      +/-   ##
==========================================
+ Coverage   75.99%   76.04%   +0.05%     
==========================================
  Files         205      205              
  Lines       11709    11748      +39     
==========================================
+ Hits         8898     8934      +36     
  Misses       2541     2541              
- Partials      270      273       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow Bot merged commit 13b2dc9 into knative:main Jun 30, 2025
35 of 37 checks passed
@dprotaso dprotaso deleted the better-url-handling branch June 30, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants