Skip to content

add startupProbe validation#16594

Merged
knative-prow[bot] merged 2 commits into
knative:mainfrom
thiagomedina:16256-add-startup-probe-validation
May 12, 2026
Merged

add startupProbe validation#16594
knative-prow[bot] merged 2 commits into
knative:mainfrom
thiagomedina:16256-add-startup-probe-validation

Conversation

@thiagomedina
Copy link
Copy Markdown
Member

@thiagomedina thiagomedina commented May 12, 2026

Fixes #16256

Proposed Changes

  • Add startup probe validation in validateUserContainer and validateSidecarContainer
  • Update existing tests that included startup probes but had no expected errors since the validation was missing

Release Note

 Add validation for startup probes in user and sidecar containers 

@knative-prow knative-prow Bot requested review from dsimansk and skonto May 12, 2026 18:09
@knative-prow knative-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.20%. Comparing base (06f2ba7) to head (9fcd924).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16594      +/-   ##
==========================================
- Coverage   80.21%   80.20%   -0.01%     
==========================================
  Files         217      217              
  Lines       13545    13550       +5     
==========================================
+ Hits        10865    10868       +3     
  Misses       2316     2316              
- Partials      364      366       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Copy Markdown
Member

Just need to run this tool on the file change

https://github.com/mvdan/gofumpt

@dprotaso
Copy link
Copy Markdown
Member

Mind filling out the release note section in your PR body?

/lgtm
/approve

thanks for the change

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented May 12, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, thiagomedina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2026
@thiagomedina
Copy link
Copy Markdown
Member Author

Mind filling out the release note section in your PR body?

sure, thanks

@knative-prow knative-prow Bot merged commit dbaab46 into knative:main May 12, 2026
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add startup probes validation for user and sidecar containers

2 participants