chore(lint): exclude goconst in test files#107
Merged
Conversation
golangci-lint v2.12.2 (pulled via 'latest' in CI) now flags repeated string literals in _test.go files, breaking lint for every PR. Repeated literals in table-driven tests are idiomatic, so exclude goconst there like errcheck. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes newly failing lint CI runs by excluding the goconst linter from _test.go files, aligning with the project’s existing approach of excluding certain linters in tests to avoid noisy/idiomatic false positives.
Changes:
- Add
goconstto the existing test-file linter exclusion rule (alongsideerrcheck) in.golangci.yaml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lintjob started failing on every PR (e.g. #106) after golangci-lintlatestresolved to v2.12.2, whosegoconstlinter now reports repeated string literals in_test.gofiles (7 issues incmd/client/utils_test.goandpkg/ports/parser_test.go).Repeated literals in table-driven tests are idiomatic, so exclude
goconstin test files, following the existingerrcheckexclusion.Verified locally with golangci-lint v2.12.2:
golangci-lint runreports 0 issues.🤖 Generated with Claude Code