This repository was archived by the owner on Jun 16, 2026. It is now read-only.
fix: apply rustfmt to resolve CI lint failures - #129
Merged
Adam Poulemanos (bashandbone) merged 2 commits intoMar 27, 2026
Merged
Conversation
Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com> Agent-Logs-Url: https://github.com/knitli/recoco/sessions/41dcb415-44ee-4e98-b75d-594cb16e94b5
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
recoco-docs | 3b64eb3 | Mar 24 2026, 10:09 PM |
Copilot
AI
changed the title
[WIP] Fix CI failures and correct issues
fix: apply rustfmt to resolve CI lint failures
Mar 24, 2026
Adam Poulemanos (bashandbone)
marked this pull request as ready for review
March 24, 2026 22:15
Adam Poulemanos (bashandbone)
requested review from
Copilot
and removed request for
Adam Poulemanos (bashandbone)
March 24, 2026 22:15
Copilot started reviewing on behalf of
Adam Poulemanos (bashandbone)
March 24, 2026 22:16
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Applies cargo fmt --all to resolve CI cargo fmt --all -- --check failures caused by recently introduced lines exceeding rustfmt’s configured width, without changing program logic.
Changes:
- Reformatted benchmark struct literals and a closure benchmark call to satisfy rustfmt line-wrapping.
- Reformatted Postgres target SQL construction and iterator chains to match rustfmt output.
- Reformatted row indexer test helpers/asserts to comply with rustfmt line-length rules.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/recoco-splitters/benches/splitting.rs | Rustfmt reflow for struct literal and a bench_with_input call in benchmarks. |
| crates/recoco-core/src/ops/targets/postgres.rs | Rustfmt reflow for identifier quoting/joining and SQL string/iterator-chain formatting. |
| crates/recoco-core/src/execution/row_indexer.rs | Rustfmt reflow for test futures construction and assertions in collect_mutation_results tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adam Poulemanos (bashandbone)
deleted the
copilot/investigate-ci-failures
branch
March 27, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI
Lint & Formatjob was failing oncargo fmt --all -- --checkdue to lines exceeding rustfmt's width limit in recently added code.Affected files
crates/recoco-core/src/execution/row_indexer.rs— Longcounted_fut()andassert!()calls in new testscrates/recoco-core/src/ops/targets/postgres.rs— Longformat!()and iterator chain expressionscrates/recoco-splitters/benches/splitting.rs— Struct literal and closure in benchmark codePure formatting changes (
cargo fmt --all), no logic modified.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.