Tracking issue for RFC 0002
#28 made solvers read inputs from BaseVehicleConfig, but several parameters they need are not in the schema, so they still come from operating_state/constants. Full proposal in PR #38 → docs/rfc/0002-componentstore-physics-fields.md.
Gaps
- Inlet-spike geometry (
cone_length_m, base_diameter_m, capture_area_m2, eta_diffuser) — powerplant/inlet.
- Combustor/nozzle losses (
pi_b, pi_cc, pi_nozzle, eta_b, h_PR, cp, gamma) — powerplant/cycle.
- Airfoil thickness / t-c — wind_tunnel/XFOIL fins.
AxisymmetricBody.nose_length_m/nose_diameter_m, Fins.chord_root_m/chord_tip_m are Optional but required by Barrowman.
RamjetEngine.fuel_type exists but is unused (h_PR hardcoded to kerosene).
Recommendation
Composable schema components (InletGeometry, CombustorLosses, AirfoilSection) over flat fields, a fuel_type → h_PR table, and per-consumer validation for the Barrowman-required fields. Classify each parameter as vehicle-property vs operating-condition before implementing.
Discuss on PR #38.
Tracking issue for RFC 0002
#28 made solvers read inputs from
BaseVehicleConfig, but several parameters they need are not in the schema, so they still come fromoperating_state/constants. Full proposal in PR #38 →docs/rfc/0002-componentstore-physics-fields.md.Gaps
cone_length_m,base_diameter_m,capture_area_m2,eta_diffuser) — powerplant/inlet.pi_b,pi_cc,pi_nozzle,eta_b,h_PR,cp,gamma) — powerplant/cycle.AxisymmetricBody.nose_length_m/nose_diameter_m,Fins.chord_root_m/chord_tip_mareOptionalbut required by Barrowman.RamjetEngine.fuel_typeexists but is unused (h_PRhardcoded to kerosene).Recommendation
Composable schema components (
InletGeometry,CombustorLosses,AirfoilSection) over flat fields, afuel_type → h_PRtable, and per-consumer validation for the Barrowman-required fields. Classify each parameter as vehicle-property vs operating-condition before implementing.Discuss on PR #38.