Skip to content

fix: report submit registry failures - #69

Closed
caioribeiroclw-pixel wants to merge 1 commit into
knoxgraeme:mainfrom
caioribeiroclw-pixel:fix-submit-json-failed-status
Closed

caioribeiroclw-pixel wants to merge 1 commit into
knoxgraeme:mainfrom
caioribeiroclw-pixel:fix-submit-json-failed-status

Conversation

@caioribeiroclw-pixel

Copy link
Copy Markdown

Summary

  • mark submit --json as failed when the registry reports a failed submission
  • include registry errors in the JSON envelope
  • exit non-zero for failed submit results instead of returning exit_code: 0

Why

While submitting caioribeiroclw-pixel/pluribus, the registry returned an HTML 429 response. skillfish submit --json surfaced the failure in failed[], but still returned success: true and exit_code: 0, which is risky for CI/agent automation.

Fixes #68.

Checks

  • npm run typecheck
  • npm test
  • git diff --check

@caioribeiroclw-pixel

Copy link
Copy Markdown
Author

Closing this in favor of maintainer PR #70, which addresses the same failure mode and is green in CI. I validated #70 locally from the reporter side and left the details there, so keeping this open would just split review attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

submit --json reports success on registry 429 failure

1 participant