Repository navigation
fix: surface clear rate-limit error for registry 429 responses - #72
Closed
knoxgraeme wants to merge 1 commit into
Closed
knoxgraeme wants to merge 1 commit into
knoxgraeme wants to merge 1 commit into
Conversation
When the registry returns HTTP 429, the body is often non-JSON (plain text / HTML). The previous code hit the generic content-type check first, producing the confusing "Registry returned non-JSON response (HTTP 429)" message. Now a dedicated 429 check runs before the content-type guard in both submitSkillsToRegistry and searchSkillsInRegistry, yielding "Registry rate limit exceeded (HTTP 429). Please try again later." with an optional seconds hint when a Retry-After header is present. Fixes #71 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AYmsc1aJ2VicCXfjxTAyRs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #71 —
skillfish submit(andskillfish search) showed a confusing "Registry returned non-JSON response (HTTP 429)" message when the registry rate-limited the request.Root cause: The non-JSON content-type guard ran before any HTTP-status check. A 429 body is typically plain text / HTML, so it fell into the generic non-JSON branch instead of producing a useful rate-limit message.
Fix:
res.status === 429check before the content-type guard in bothsubmitSkillsToRegistryandsearchSkillsInRegistryinsrc/lib/registry.tsRetry-Afterheader is present)Test plan
src/__tests__/registry.test.tscovers both functions: clear error on bare 429, andRetry-Afterseconds hintnpm test)npm run typecheck)🤖 Generated with Claude Code
https://claude.ai/code/session_01AYmsc1aJ2VicCXfjxTAyRs
Generated by Claude Code