Skip to content

fix(tests): invoke the CLI without npx so the suite runs on Windows #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HeversonSilva-gif wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tests): invoke the CLI without npx so the suite runs on Windows #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/__tests__/invoke-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,10 @@ export interface CliResult {
*/
export function invokeCli(args: string[]): CliResult {
try {
// Use execFileSync with array args to prevent shell injection
const stdout = execFileSync('npx', ['tsx', CLI_PATH, ...args], {
// Use execFileSync with array args to prevent shell injection.
// Run node directly with tsx as a loader rather than going through npx: on Windows
// npx is a .cmd shim, which execFileSync cannot launch without a shell.
const stdout = execFileSync(process.execPath, ['--import', 'tsx', CLI_PATH, ...args], {
encoding: 'utf-8',
stdio: ['pipe', 'pipe', 'pipe'],
});
Expand Down