This repository was archived by the owner on Feb 14, 2018. It is now read-only.
Files in hidden directories shouldn't be sent to client#5
Open
yf-hk wants to merge 5 commits intokoajs:masterfrom
yf-hk:patch-1
Open
Files in hidden directories shouldn't be sent to client#5yf-hk wants to merge 5 commits intokoajs:masterfrom yf-hk:patch-1
yf-hk wants to merge 5 commits intokoajs:masterfrom
yf-hk:patch-1
Conversation
Since we shouldn't match the result in base path. For example '/var/.webroot/abc.txt'
fix the broken test. sorry it's a bit ugly used regex `look behind` (negative matching) clause
Author
|
Sorry, I couldn't fix the test. But hopefully you see the point |
yf-hk
changed the title
yf-hk
changed the title
Member
|
@andyhu rebase with master, tests should be passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If option
hiddenis set, I think it should also check that if any of the directory in the path is hidden. Otherwise something like/test/public/.git/configmight also pass the filter which is apparently not right.