refactor(proto): replace raw lat/lng in PizzintLocation with GeoCoordinates#811
Open
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Open
refactor(proto): replace raw lat/lng in PizzintLocation with GeoCoordinates#811NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Conversation
…inates Replace the raw `double lat` (field 12) and `double lng` (field 13) fields in PizzintLocation with a structured `GeoCoordinates location` (field 14) message from worldmonitor.core.v1. Old field numbers 12, 13 and names "lat", "lng" are reserved for wire compatibility. Updates server handler, client adapter, generated TypeScript types, and OpenAPI specs to use location.latitude / location.longitude. Closes koala73#189 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
koala73
added
Not Ready to Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
double lat(field 12) anddouble lng(field 13) inPizzintLocationproto message with a structuredGeoCoordinates location(field 14) fromworldmonitor.core.v1get-pizzint-status.ts) to constructGeoCoordinatesobjects from upstream API lat/lng valuessrc/services/pizzint.ts) to readlocation.latitude/location.longitudeinstead oflat/lngCloses #189
Test plan
buf lintpasses on the updated protomake generateproduces matching TypeScript typeslocationobject field gracefully (oldlat/lngfields are no longer present in responses)🤖 Generated with Claude Code