fix(api): add AbortSignal.timeout to unprotected fetch calls#825
Open
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Open
fix(api): add AbortSignal.timeout to unprotected fetch calls#825NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortSignal.timeout(15_000)to the two unprotectedfetch()calls inserver/worldmonitor/research/v1/list-tech-events.ts(ICS and RSS background fetches)AbortSignal.timeout(15_000)to the unprotectedfetch()call inserver/worldmonitor/displacement/v1/get-displacement-summary.ts(UNHCR Population API)fetch()calls inserver/worldmonitor/without asignaloption; all other fetches already had timeout protectionFiles modified
server/worldmonitor/research/v1/list-tech-events.ts15_000(15s)server/worldmonitor/displacement/v1/get-displacement-summary.ts15_000(15s)Test plan
list-tech-eventsstill returns results when ICS/RSS sources are reachablelist-tech-eventsgracefully handles timeout (Promise.allSettled already handles rejection)get-displacement-summarystill returns UNHCR data normallyget-displacement-summaryreturnsnullon timeout (existingtry/response check handles it)npm run typecheck— confirmed passing🤖 Generated with Claude Code