perf(ui): replace wildcard D3 imports with named imports for tree-shaking#841
Open
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Open
perf(ui): replace wildcard D3 imports with named imports for tree-shaking#841NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
NewCoder3294 wants to merge 1 commit intokoala73:mainfrom
Conversation
…king Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import * as d3 from 'd3'with named imports in 5 components to enable better tree-shaking and reduce bundle sized3.xxx()call sites updated to use direct function calls (e.g.,select(),scaleLinear(),extent())d3.Selection,d3.GeoProjection, etc.) updated to use named type importsFiles changed
src/components/ProgressChartsPanel.tsselect,extent,scaleLinear,area,curveMonotoneX,line,axisBottom,axisLeft,bisector,pointer+ typesSelection,ScaleLinearsrc/components/SpeciesComebackPanel.tsselect,extent,max,scaleLinear,area,curveMonotoneX,linesrc/components/RenewableEnergyPanel.tsselect,arc,interpolate,easeCubicOut,extent,scaleLinear,area,curveMonotoneX,line,stack,stackOrderNone,stackOffsetNone,max+ typeSeriesPointsrc/components/Map.tsselect,geoPath,geoEquirectangular,geoGraticule,line(asd3Line),curveCardinal+ typesSelection,GeoProjection,GeoPathsrc/components/CountryTimeline.tsselect,scaleTime,scaleBand,axisBottom,timeFormat+ typesSelection,ScaleTime,ScaleBand,NumberValueBundle size impact
With wildcard imports (
import * as d3 from 'd3'), bundlers must include the entire D3 library (~500KB unminified) even if only a handful of functions are used. Named imports allow tree-shaking to eliminate unused D3 modules, potentially reducing the D3 contribution to the bundle by 60-80% depending on the bundler configuration.Test plan
tsc --noEmitpasses with zero errors🤖 Generated with Claude Code