Conversation
The recommended player.sequence(async (scene) => {...}) entry point runs
its callback detached from the promise render() awaits, so a throw inside
the scene was an unhandled promise rejection visible only in the browser
console — the widget rendered blank and widget.error stayed "". Add a
window unhandledrejection listener that routes those into the existing
showError() surface (error box + traitlet), cleaned up on teardown.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291. A
ManimWebscene's runtime errors were invisible: the recommendedplayer.sequence(async (scene) => {...})entry point runs its callback detached from the promiserender()awaits, so a throw inside the scene became an unhandled promise rejection seen only in the browser console — the widget rendered blank andwidget.errorstayed"". This adds a per-instance windowunhandledrejectionlistener that routes those errors through the existingshowError()surface, so scene bugs now render in the cell and are readable from Python. The listener is guarded by adisposedflag and removed on teardown, and the CHANGELOG gets an## [Unreleased]entry. Known caveat (documented in a code comment):unhandledrejectionis page-global, so with multiple live ManimWeb widgets a rejection from one may be reported by all — an accepted trade-off for the single-widget iteration use case.🤖 Generated with Claude Code