[Client] Improve stop() handling when it triggers PCSC shutdown errors#2
Merged
Conversation
Ran into an edge case while adding stop/resume functionality to the E2E app - if the client is is stopped while waiting on state updates, a `NoService` error code is returned (at least on macos so far). Was previously only ignoring the `Cancelled` code, so the app exits on the unexpected error - switching to tracking the running state of the client in JS and ignoring errors while we're explicitly shutting down. Bumping patch version to v0.1.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into an edge case while adding stop/resume functionality to the E2E app - if the client is is stopped while waiting on state updates, a
NoServiceerror code is returned (at least on macos so far).Was previously only ignoring the
Cancelledcode, so the app exits on the unexpected error - switching to tracking the running state of the client in JS and ignoring errors while we're explicitly shutting down.Bumping patch version to v0.1.2.