[fix][win32] Enable running under Bun and Electron#7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing: #3, #5
Overview
Clients running non-Node.js runtimes on Windows were previously crashing when importing
pcsc-mini, due to a limitation in how Node-API symbol lookups happen for addons built with Tokota - more context in kofi-q/tokota#13.Upgrading the Tokota dependency to the current latest to get the fix, which involves generating separate optional packages for each supported runtime. This is hopefully temporary, until there's support added to Zig for delay-loading symbols from the calling runtime instead of a hardcoded executable name.