Skip to content

Support different windows exe names#29

Open
liamcmitchell wants to merge 22 commits into
kofi-q:mainfrom
liamcmitchell:win_dll
Open

Support different windows exe names#29
liamcmitchell wants to merge 22 commits into
kofi-q:mainfrom
liamcmitchell:win_dll

Conversation

@liamcmitchell

@liamcmitchell liamcmitchell commented Feb 19, 2026

Copy link
Copy Markdown

Hi, cool libraries! I bumped into kofi-q/pcsc-mini#13 when packaging pcsc-mini into an electron app. This is my attempt at fixing it.

  • bumps zig to latest, i couldn't download the windows binaries for the prev version
  • adds a new dynamic win32 runtime option which looks up methods lazily, trying to mimic node-gyp & delay-load behavior
  • makes dynamic the default, preserves support for static exe linking
  • refactors other source generators to run directly, no need for running through node
  • adds GENERATED headers to files, should help anyone stumbling across them
  • removes unused file _build/testing.zig
  • adds win32-runtime flag and examples:*:build steps for easier testing e.g. zig build examples:add:build -Dtarget=x86_64-windows -Dwin32-runtime=deno
  • adds symbols_check step to check latest symbols match git
  • adds test_win step to ensure win static and dynamic runtimes compile
  • added addRuntimeArchCheck to make sure node/deno/bun tests are only run against expected arch (i had x64 bun trying to load arm64 addons)

I used these changes to rebuild pcsc-mini on macOS and with these packages, successfully interacted with a card reader in my packaged electron app on Windows.

@liamcmitchell

Copy link
Copy Markdown
Author

Hi @kofi-q, please let me know if you are interested in these changes and if so, what timeframe you might look at them.

@kofi-q

kofi-q commented Feb 28, 2026

Copy link
Copy Markdown
Owner

Thanks for taking the time to work on this! Been hoping to get a workaround for this issue for while. Will take a look this weekend and test it out - looks great so far from skimming it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants