Support different windows exe names#29
Open
liamcmitchell wants to merge 22 commits into
Open
Conversation
Author
|
Hi @kofi-q, please let me know if you are interested in these changes and if so, what timeframe you might look at them. |
Owner
|
Thanks for taking the time to work on this! Been hoping to get a workaround for this issue for while. Will take a look this weekend and test it out - looks great so far from skimming it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, cool libraries! I bumped into kofi-q/pcsc-mini#13 when packaging pcsc-mini into an electron app. This is my attempt at fixing it.
bumps zig to latest, i couldn't download the windows binaries for the prev versiondynamicwin32 runtime option which looks up methods lazily, trying to mimic node-gyp & delay-load behaviorwin32-runtimeflag andexamples:*:buildsteps for easier testing e.g.zig build examples:add:build -Dtarget=x86_64-windows -Dwin32-runtime=denoI used these changes to rebuild pcsc-mini on macOS and with these packages, successfully interacted with a card reader in my packaged electron app on Windows.