Restore HTTP request-latency histogram buckets in Prometheus metrics - #1095
Merged
Merged
Conversation
The metric filter still matched the old jetty.server.requests timer, but Javalin renamed it to http.server.requests, so percentile histograms were never enabled and the http_server_requests_seconds_bucket series vanished. Match the current name and add regression tests (filter-level plus an end-to-end scrape).
Collaborator
|
Claude's chattiness (I presume this is Claude) is becoming a problem. It takes me twice as long to read the comments as it takes to read the code they comment. Could you instruct it to keep comments to a minimum and have a single comment not exceed 2 lines? |
Contributor
Author
|
Haha, it's indeed very chatty. I've already tuned it down quite a bit, but it seems I need to tighten that thumbscrew some more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metric filter still matched the old jetty.server.requests timer, but Javalin renamed it to http.server.requests, so percentile histograms were never enabled and the http_server_requests_seconds_bucket series vanished. Match the current name and add regression tests (filter-level plus an end-to-end scrape).