Scale down importance according to search rank of the object - #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wikipedia-based importances can yield rather high values, when a wikipedia link of an OSM object refers to an organisation rather than to the actual location, for example when the head quarter of a company is tagged. This is not much of an issue for Nominatim because the objects in question usually have rather long names. With its strong bias on full names and preference of objects with higher rank, Nominatim will rarely have them float up. In Photon these importance create serious issues because the basic search is based on single-word tokens rather than on full names.
This PR scales importances down, once they go over a per-rank threshold. The threshold is the lower, the higher the rank is. So organisations, which are usually at POI level (rank 30), will be most affected.
This won't make the false positive results go away but at least it will push them down a bit for ranking.