Improve searchability of postcodes with optional spaces and dashes - #1105
Merged
Conversation
The field provides properly formatted postcodes and drops the ones that do not comply to the country's format. That should lead to better results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes so that postcodes containing spaces or dashes are also searchable when omitting spaces/dashes:
There is one more change to the Nominatim export to make that work properly: postcodes for places are now always taken from the
postcodecolumn. The value ofaddr:postcodeis ignored. That's done becausepostcodeis guaranteed to contain a valid, normalized version of the postcode with spaces intact while mapping of postcodes in OSM varies.Please note that there are a few countries where Nominatim works with the postcode without spaces, for example in India. If you want a Photon database which supports both versions, you need to change the postcode output in Nominatim's country settings. The Graphhopper exports work with the standard postcode settings