fix: return after DNS resolve failure in checkIfIpIsLive - #1017
Open
VedantMadane wants to merge 1 commit into
Open
fix: return after DNS resolve failure in checkIfIpIsLive#1017VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
- Missing return after ResolveTCPAddr error led to nil pointer panic on DialTimeout. Fixes konflux-ci#985 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
|
🤖 Finished Review · ✅ Success · Started 6:58 PM UTC · Completed 7:07 PM UTC Commit: |
|
Looks good to me Labels: PR fixes a nil-pointer panic bug in IBM cloud provider helper (pkg/ibm/), single-line change with minimal review effort |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: return after DNS resolve failure in checkIfIpIsLive
Changes
Fixes #985