Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/agent-files-detect.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false

Expand Down Expand Up @@ -56,7 +56,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
fetch-depth: 0
persist-credentials: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-merge.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
checks: read
statuses: read
steps:
- uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] inconsistent-version-comment-format

Version comment uses '# v7' while go-ci.yaml, mpc-test.yaml, and test-e2e.yml use '# v7.0.1' for the identical SHA 3d3c42e5aac5ba805825da76410c181273ba90b1. This inconsistency was inherited from the baseline (# v6 vs # v6.1.0) and preserved by Renovate.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] consistency

Version comment uses major-only format # v7 while most other workflow files use detailed format # v7.0.1 for the same action version. This inconsistency pre-dates the PR — Renovate preserved each file's existing comment convention.

Suggested fix: Change comment from # v7 to # v7.0.1 to match the detailed format used in other workflow files.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] version-comment-inconsistency

Version comments are inconsistent: auto-merge.yaml and dep-triage.yaml use # v7 while the other four files use # v7.0.1. All reference the same SHA. This is a pre-existing pattern preserved by the bot, not a regression.

Suggested fix: Standardize to # v7.0.1 across all workflow files.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] credential-exposure

Pre-existing: 5 of 6 workflows check out code without persist-credentials: false. Not introduced by this PR. Only agent-files-detect.yaml correctly sets this option.

Suggested fix: Add persist-credentials: false to checkout steps that don't need git push capabilities.

- uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3
id: app-token
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/dep-triage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ jobs:
checks: read
statuses: read
steps:
- uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6
- uses: konflux-ci/deptriage@2dd6abf230fc792c4fa7dd9aac58b20731b90acd # main
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] inconsistent-version-comment-format

Version comment uses '# v7' while go-ci.yaml, mpc-test.yaml, and test-e2e.yml use '# v7.0.1' for the identical SHA. Same inherited inconsistency as auto-merge.yaml.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] consistency

Version comment uses major-only format # v7 while most other workflow files use detailed format # v7.0.1 for the same action version. This inconsistency pre-dates the PR — Renovate preserved each file's existing comment convention.

Suggested fix: Change comment from # v7 to # v7.0.1 to match the detailed format used in other workflow files.

- uses: konflux-ci/deptriage@50bf2bb8e60186927f31de5d199ddd30e3229484 # main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] scope-exceeded

PR title claims 'Update actions/checkout action to v7' but the diff includes a second dependency update: konflux-ci/deptriage from hash 2dd6abf230fc792c4fa7dd9aac58b20731b90acd to 50bf2bb8e60186927f31de5d199ddd30e3229484. Bundling multiple dependency updates without disclosure makes rollback and bisection harder.

Suggested fix: Either update the PR title/description to reflect both changes, or split into two PRs.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] supply-chain/hash-verification

The konflux-ci/deptriage action hash is updated (from 2dd6abf2 to 50bf2bb8) as part of this PR but is not mentioned in the PR title or description. The new hash should be verified against the expected main branch commit of konflux-ci/deptriage.

Suggested fix: Verify that commit 50bf2bb8e60186927f31de5d199ddd30e3229484 corresponds to a legitimate commit on the main branch of konflux-ci/deptriage.

with:
command: both
pr-number: ${{ github.event.pull_request.number }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/go-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- name: Install Go
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
with:
Expand All @@ -39,7 +39,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- name: Install Go
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/mpc-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
echo "Invalid context for this workflow run. Exiting."
exit 1
- name: Check out code
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- name: Install Go
uses: actions/setup-go@4a3601121dd01d1626a1e23e37211e3254c1c06c # v6
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
docker-images: false

- name: Clone the code
uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6.1.0
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@e6de054238d6b7531b4efff3b6587d9aade6a06c # v6.2.3
Expand Down
Loading