-
Notifications
You must be signed in to change notification settings - Fork 46
Update actions/checkout action to v7 #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| checks: read | ||
| statuses: read | ||
| steps: | ||
| - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6 | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] consistency Version comment uses major-only format Suggested fix: Change comment from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] version-comment-inconsistency Version comments are inconsistent: auto-merge.yaml and dep-triage.yaml use Suggested fix: Standardize to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] credential-exposure Pre-existing: 5 of 6 workflows check out code without persist-credentials: false. Not introduced by this PR. Only agent-files-detect.yaml correctly sets this option. Suggested fix: Add persist-credentials: false to checkout steps that don't need git push capabilities. |
||
| - uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3 | ||
| id: app-token | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,8 @@ jobs: | |
| checks: read | ||
| statuses: read | ||
| steps: | ||
| - uses: actions/checkout@d23441a48e516b6c34aea4fa41551a30e30af803 # v6 | ||
| - uses: konflux-ci/deptriage@2dd6abf230fc792c4fa7dd9aac58b20731b90acd # main | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] inconsistent-version-comment-format Version comment uses '# v7' while go-ci.yaml, mpc-test.yaml, and test-e2e.yml use '# v7.0.1' for the identical SHA. Same inherited inconsistency as auto-merge.yaml. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] consistency Version comment uses major-only format Suggested fix: Change comment from |
||
| - uses: konflux-ci/deptriage@50bf2bb8e60186927f31de5d199ddd30e3229484 # main | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] scope-exceeded PR title claims 'Update actions/checkout action to v7' but the diff includes a second dependency update: konflux-ci/deptriage from hash 2dd6abf230fc792c4fa7dd9aac58b20731b90acd to 50bf2bb8e60186927f31de5d199ddd30e3229484. Bundling multiple dependency updates without disclosure makes rollback and bisection harder. Suggested fix: Either update the PR title/description to reflect both changes, or split into two PRs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] supply-chain/hash-verification The konflux-ci/deptriage action hash is updated (from 2dd6abf2 to 50bf2bb8) as part of this PR but is not mentioned in the PR title or description. The new hash should be verified against the expected main branch commit of konflux-ci/deptriage. Suggested fix: Verify that commit 50bf2bb8e60186927f31de5d199ddd30e3229484 corresponds to a legitimate commit on the main branch of konflux-ci/deptriage. |
||
| with: | ||
| command: both | ||
| pr-number: ${{ github.event.pull_request.number }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[low] inconsistent-version-comment-format
Version comment uses '# v7' while go-ci.yaml, mpc-test.yaml, and test-e2e.yml use '# v7.0.1' for the identical SHA 3d3c42e5aac5ba805825da76410c181273ba90b1. This inconsistency was inherited from the baseline (# v6 vs # v6.1.0) and preserved by Renovate.