-
Notifications
You must be signed in to change notification settings - Fork 46
Bump actions/checkout from 6.0.2 to 7.0.0 #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ jobs: | |
| checks: read | ||
| statuses: read | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] version comment mismatch The checkout action is updated to commit 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 (v7.0.0 per the PR title and the annotations in the other three workflow files), but the version comment still says '# v6'. Since all five workflow files now pin the same commit hash, this comment is objectively stale. Suggested fix: Change the comment from '# v6' to '# v7.0.0'. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] version-comment-inconsistency The version comment says '# v6' but the commit hash 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 corresponds to actions/checkout v7.0.0. Other files in this PR correctly use '# v7.0.0'. Suggested fix: Update the comment from '# v6' to '# v7.0.0'. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] version-comment-mismatch The PR updates the pinned hash to 9c091bb2... (actions/checkout v7.0.0) but leaves the version comment as # v6. The other three workflow files correctly label the same hash as # v7.0.0. Suggested fix: Update the comment from # v6 to # v7 or # v7.0.0. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] stale-comment The version comment says '# v6' but the commit SHA 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 corresponds to v7.0.0 (correctly labeled in go-ci.yaml, mpc-test.yaml, and test-e2e.yml). Suggested fix: Update the comment from '# v6' to '# v7.0.0'. |
||
| - uses: actions/create-github-app-token@bcd2ba49218906704ab6c1aa796996da409d3eb1 # v3 | ||
| id: app-token | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ jobs: | |
| checks: read | ||
| statuses: read | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v6 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] version comment inconsistency Same issue as auto-merge.yaml: the commit hash is updated to the v7.0.0 SHA but the version comment still says # v6. Suggested fix: Change the comment from # v6 to # v7.0.0 to match the actual version being pinned. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [medium] version comment mismatch The checkout action is updated to commit 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 (v7.0.0) but the version comment still says '# v6'. All other workflow files in this PR correctly annotate this hash as '# v7.0.0'. Suggested fix: Change the comment from '# v6' to '# v7.0.0'. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] version-comment-inconsistency The version comment says '# v6' but the commit hash 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 corresponds to actions/checkout v7.0.0. Other files in this PR correctly use '# v7.0.0'. Suggested fix: Update the comment from '# v6' to '# v7.0.0'. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] version-comment-mismatch Same as auto-merge.yaml: the PR updates the pinned hash to the v7.0.0 commit but leaves the version comment as # v6. Suggested fix: Update the comment from # v6 to # v7 or # v7.0.0. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [low] stale-comment Same issue: the version comment says '# v6' but the commit SHA points to v7.0.0. Suggested fix: Update the comment from '# v6' to '# v7.0.0'. |
||
| - uses: konflux-ci/deptriage@993b534180800943a8c05601151fb34ecb376445 # main | ||
| with: | ||
| command: both | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[medium] version comment inconsistency
The commit hash is updated to 9c091bb (v7.0.0) but the version comment still says # v6 instead of # v7.0.0. Misleading for future audits.
Suggested fix: Change the comment from # v6 to # v7.0.0 to match the actual version being pinned.