Skip to content

KONFLUX-14156(#945): add curl retry to OTP server calls #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fullsend-ai-coder wants to merge 2 commits into
base: main
Choose a base branch
from
Open

KONFLUX-14156(#945): add curl retry to OTP server calls #946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1460d3a
KONFLUX-14156(#945): add curl retry to OTP server calls
fullsend-ai-coder[bot] Jun 22, 2026
b655611
fix: add connect-timeout and max-time to OTP curl calls
fullsend-ai-coder[bot] Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/operator/provision-host-macos.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ DIR=$(echo "/Users/${USERNAME}" | base64 -w 0)
if [ -e "/tls/tls.crt" ]; then
echo "{message: \"Creating secret file using TLS certificate...\", level: \"INFO\"}"
KEY=$(cat id_rsa)
if ! otp_raw=$(curl --fail --cacert /tls/tls.crt -XPOST -d "$KEY" https://multi-platform-otp-server.multi-platform-controller.svc.cluster.local/store-key); then
if ! otp_raw=$(curl --fail --connect-timeout 5 --max-time 30 --retry 3 --retry-all-errors --retry-delay 1 --cacert /tls/tls.crt -XPOST -d "$KEY" https://multi-platform-otp-server.multi-platform-controller.svc.cluster.local/store-key); then
echo "{message: \"Failed to store SSH key in OTP server. Please, retry build in a few minutes, and if problem persists, please report it as an MPC bug.\", level: \"ERROR\"}" >&2
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion deploy/operator/provision-host-windows.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ DIR=$(echo 'C:\\Users\\'"${USERNAME}" | base64 -w 0)
if [ -e "/tls/tls.crt" ]; then
echo "{message: \"Creating secret file using TLS certificate...\", level: \"INFO\"}"
KEY=$(cat id_rsa)
if ! otp_raw=$(curl --fail --cacert /tls/tls.crt -XPOST -d "$KEY" https://multi-platform-otp-server.multi-platform-controller.svc.cluster.local/store-key); then
if ! otp_raw=$(curl --fail --connect-timeout 5 --max-time 30 --retry 3 --retry-all-errors --retry-delay 1 --cacert /tls/tls.crt -XPOST -d "$KEY" https://multi-platform-otp-server.multi-platform-controller.svc.cluster.local/store-key); then
echo "{message: \"Failed to store SSH key in OTP server. Please, retry build in a few minutes, and if problem persists, please report it as an MPC bug.\", level: \"ERROR\"}" >&2
exit 1
fi
Expand Down
2 changes: 1 addition & 1 deletion deploy/operator/provision-shared-host.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ DIR=$(echo /home/"$USERNAME" | base64 -w 0)
if [ -e "/tls/tls.crt" ]; then
echo "{message: \"Creating secret file using TLS certificate...\", level: \"INFO\"}"
KEY=$(cat id_rsa)
if ! otp_raw=$(curl --fail --cacert /tls/tls.crt -XPOST -d "$KEY" https://multi-platform-otp-server.multi-platform-controller.svc.cluster.local/store-key); then
if ! otp_raw=$(curl --fail --connect-timeout 5 --max-time 30 --retry 3 --retry-all-errors --retry-delay 1 --cacert /tls/tls.crt -XPOST -d "$KEY" https://multi-platform-otp-server.multi-platform-controller.svc.cluster.local/store-key); then

@fullsend-ai-review fullsend-ai-review Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] inconsistent-retry-pattern

The curl retry flags for the OTP server call (--connect-timeout 5 --max-time 30) differ from the existing curl retry pattern at line 46 (--connect-timeout 10 --max-time 120). The difference is justified (in-cluster OTP POST vs. external GitHub download), but a brief inline comment explaining the rationale would aid future maintainers.

Suggested fix: Consider adding a brief comment explaining why the OTP server curl uses shorter timeouts than the GitHub download curl, to aid future maintainers.

echo "{message: \"Failed to store SSH key in OTP server. Please, retry build in a few minutes, and if problem persists, please report it as an MPC bug.\", level: \"ERROR\"}" >&2
exit 1
fi
Expand Down
Loading