fix: correct base54val variable name to base64val in pkg/aws/ec2.go

[Jah-yee]

Summary

Fixes a variable naming typo in pkg/aws/ec2.go: base54val → base64val.

The issue

The variable base54val is assigned the result of base64.StdEncoding.EncodeToString(...) but is incorrectly named base54val instead of base64val.

Fix

Renamed the variable from base54val to base64val (2 occurrences on lines 55 and 56).

Testing

Go compiler verified: go build ./...

---

Fixes #987

[qodo-app-for-konflux-ci]

PR Summary by Qodo

Correct base64 variable names in EC2 encoding

🐞 Bug fix 🕐 Less than 5 minutes

AI Description

• Corrects misleading base54val names in EC2 user-data encoding.
• Aligns the test helper variable with Go's base64 encoder.

High-Level Assessment

A direct rename is optimal because it corrects the misleading identifier without changing behavior, APIs, or test coverage. No architectural alternative is warranted.

Files changed (2) +4 / -4

Bug fix (2) +4 / -4

ec2.goCorrect base64-encoded user-data variable name +2/-2

Correct base64-encoded user-data variable name

• Renames 'base54val' to 'base64val' so the local identifier accurately describes the encoded EC2 user data. Runtime behavior remains unchanged.

pkg/aws/ec2.go

ec2_test.goCorrect base64 variable name in test helper +2/-2

Correct base64 variable name in test helper

• Renames the matching local variable in 'stringEncode' to reflect its base64-encoded value. Test behavior remains unchanged.

pkg/aws/ec2_test.go

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 4:15 AM UTC · Completed 4:22 AM UTC
Commit: 37b10e4 · View workflow run →

[qodo-app-for-konflux-ci]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can add REVIEW.md to your repo root and Qodo follows it on every PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Previous reviews

Review updated until commit 209ccc9 ⚖️ Balanced

Results up to commit 07a16fb ⚖️ Balanced

No changes from previous review

Results up to commit e21accb ⚖️ Balanced

No changes from previous review

Results up to commit 4ef9f6d ⚖️ Balanced

No changes from previous review

Results up to commit ebc59d3 ⚖️ Balanced

No changes from previous review

[fullsend-ai-review]

Looks good to me

Previous run

Looks good to me

Previous run (2)

Looks good to me

Previous run (3)

Looks good to me

Previous run (4)

Looks good to me

Previous run (5)

Review

Findings

Low

• [naming-consistency] pkg/aws/ec2_test.go:20 — The same base54val typo exists in ec2_test.go at lines 20-21 in the stringEncode helper function but was not fixed in this PR. For consistency, both instances of the typo should be corrected together.
  Remediation: Apply the same rename (base54val → base64val) to pkg/aws/ec2_test.go:20-21 to maintain consistency across the codebase.

---

Labels: PR fixes a variable naming typo in AWS EC2 cloud provider code

[fullsend-ai-review]

🤖 Review · ❌ Terminated · Started 5:20 AM UTC · Ended 5:27 AM UTC
Commit: 37b10e4 · View workflow run →

[qodo-app-for-konflux-ci]

Code review by qodo was updated up to the latest commit e21accb

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 5:20 AM UTC · Completed 5:27 AM UTC
Commit: 37b10e4 · View workflow run →

[fullsend-ai-review]

🤖 Review · ❌ Terminated · Started 7:24 PM UTC · Ended 7:31 PM UTC
Commit: d5d3758 · View workflow run →

[qodo-app-for-konflux-ci]

Code review by qodo was updated up to the latest commit 4ef9f6d

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 7:24 PM UTC · Completed 7:31 PM UTC
Commit: d5d3758 · View workflow run →

[fullsend-ai-review]

🤖 Review · ❌ Terminated · Started 3:19 PM UTC · Ended 3:26 PM UTC
Commit: 701e62a · View workflow run →

[qodo-app-for-konflux-ci]

Code review by qodo was updated up to the latest commit ebc59d3

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 3:19 PM UTC · Completed 3:26 PM UTC
Commit: 701e62a · View workflow run →

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.06%. Comparing base (b94c9eb) to head (209ccc9).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   76.74%   77.06%   +0.31%     
==========================================
  Files          26       26              
  Lines        2817     2817              
==========================================
+ Hits         2162     2171       +9     
+ Misses        456      449       -7     
+ Partials      199      197       -2     

Flag	Coverage Δ
unit-tests	73.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
pkg/aws/ec2.go	88.50% <100.00%> (ø)

... and 3 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94c9eb...209ccc9. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Jah-yee]

👋 Hi @mshaposhnik! I've rebased this PR onto the latest main (33aad84) to resolve the divergence. The fix (base54val → base64val) is unchanged — just updated to the current main tip. CI checks are running now. Let me know if you need anything else!

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 9:25 AM UTC · Completed 9:36 AM UTC

Commit: 9ee3c25 · View workflow run →

[Jah-yee]

Hi @mshaposhnik — following up on this PR. The maintainer approvals are in place, and I see CI is still queued. Please let me know if there's anything I can help with to move this forward!

[Jah-yee]

Friendly ping — just checking if there's anything else needed to move this forward. Happy to address any feedback!

[mshaposhnik]

/ok-to-test

[mshaposhnik]

/retest-required

[mshaposhnik]

/retest

[qodo-app-for-konflux-ci]

Code review by qodo was updated up to the latest commit 209ccc9

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 4:04 PM UTC · Completed 4:15 PM UTC

Commit: 9ee3c25 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.31

[fullsend-ai-review]

Risk Assessment: low (1/5)

Details

Cosmetic variable rename (base54val to base64val) in 2 files with perfect test coverage, zero recent churn, stable code (123d unchanged), and exact match to issue scope.

[mshaposhnik]

/ok-to-test