Skip to content

feat: add common infrastructure clusters to oclogin-all - #94

Merged
jhutar merged 3 commits into
konflux-ci:mainfrom
smodak-rh:feat/add-common-clusters-to-oclogin-all
Aug 25, 2026
Merged

feat: add common infrastructure clusters to oclogin-all#94
jhutar merged 3 commits into
konflux-ci:mainfrom
smodak-rh:feat/add-common-clusters-to-oclogin-all

Conversation

@smodak-rh

Copy link
Copy Markdown
Contributor

Summary

  • Adds 4 common infrastructure clusters (kflux-c-prd-e01, kflux-c-prd-i01, kflux-c-stg-e01, kflux-c-stg-i01) to the CLUSTERS variable in oclogin-all
  • These clusters are already registered in oclogin (lines 98-101) — this change makes oclogin-all include them in its login sweep
  • Requested by Jan Hutar in KONFLUX-15435 to extend OOM/CrashLoopBackOff monitoring to common infrastructure clusters

Test plan

  • oclogin-all --dry-run lists all 4 common clusters and correctly resolves their API URLs (0 UNKNOWN)
  • oclogin-all successfully authenticates to all 4 common clusters (web login flow)

Assisted-by: ClaudeAI

🤖 Generated with Claude Code

@qodo-app-for-konflux-ci

Copy link
Copy Markdown

PR Summary by Qodo

Include common infrastructure clusters in oclogin-all

✨ Enhancement ⚙️ Configuration changes 🕐 Less than 5 minutes

Grey Divider

AI Description

• Adds four production and staging common infrastructure clusters to the login sweep.
• Extends monitoring coverage using cluster mappings already registered in oclogin.
High-Level Assessment

The targeted list extension is appropriate because oclogin-all maintains a curated login sweep while oclogin already owns URL resolution. Dynamically importing every oclogin cluster was considered but would broaden the sweep beyond the explicitly requested infrastructure clusters.

Files changed (1) +1 / -1

Enhancement (1) +1 / -1
oclogin-allAdd common infrastructure clusters to the login sweep +1/-1

Add common infrastructure clusters to the login sweep

• Extends 'CLUSTERS' with four production and staging common infrastructure clusters. This enables 'oclogin-all' to resolve and authenticate against those existing 'oclogin' registrations for broader monitoring coverage.

tools/tasks-and-steps-resource-analyzer/oclogin-all

@qodo-app-for-konflux-ci

qodo-app-for-konflux-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Documented cluster count outdated ✓ Resolved 🐞 Bug ⚙ Maintainability
Description
Extending CLUSTERS to 16 entries leaves the analyzer README claiming that oclogin-all handles
only 12 clusters. Users following the authentication instructions therefore receive an incorrect
description of the login sweep.
Code

tools/tasks-and-steps-resource-analyzer/oclogin-all[38]

+CLUSTERS="stone-prd-rh02 kflux-ocp-p01 kflux-osp-p01 kflux-prd-es01 kflux-prd-rh03 kflux-rhel-p01 kflux-stg-es01 stone-prd-rh01 stone-prod-p01 stone-prod-p02 stone-stage-p01 stone-stg-rh01 kflux-c-prd-e01 kflux-c-prd-i01 kflux-c-stg-e01 kflux-c-stg-i01"
Evidence
The modified list contains 16 cluster names, while both authentication sections still explicitly
describe oclogin-all as operating on 12 clusters.

tools/tasks-and-steps-resource-analyzer/oclogin-all[36-38]
tools/tasks-and-steps-resource-analyzer/README.md[27-40]
tools/tasks-and-steps-resource-analyzer/README.md[242-250]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`oclogin-all` now processes 16 clusters, but its README still states that it handles 12.

## Issue Context
Update each user-facing cluster-count reference associated with `oclogin-all` so the documentation matches the expanded `CLUSTERS` list.

## Fix Focus Areas
- tools/tasks-and-steps-resource-analyzer/README.md[27-40]
- tools/tasks-and-steps-resource-analyzer/README.md[242-250]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Context sources
✅ Compliance rules (platform): 4 rules

Grey Divider

Tip of the day
💡 Did you know, you can hide the parts of a finding you never read, like the evidence or the agent prompt

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread tools/tasks-and-steps-resource-analyzer/oclogin-all
smodak-rh and others added 2 commits August 19, 2026 18:00
Add kflux-c-prd-e01, kflux-c-prd-i01, kflux-c-stg-e01, kflux-c-stg-i01
to the CLUSTERS variable so oclogin-all covers all common infrastructure
clusters requested in KONFLUX-15435.

Signed-off-by: Subrata Modak <smodak@redhat.com>
Assisted-by: ClaudeAI
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reflects the 4 common infrastructure clusters added to oclogin-all.

Signed-off-by: Subrata Modak <smodak@redhat.com>
Assisted-by: ClaudeAI
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@smodak-rh
smodak-rh force-pushed the feat/add-common-clusters-to-oclogin-all branch from 67a57bb to b7c5617 Compare August 19, 2026 22:02
HCP (Hosted Control Plane) ROSA clusters on .p3.openshiftapps.com use
a different API URL format: api.<cluster>.p3:443 (no "rosa." prefix,
port 443 not 6443). The oclogin helper auto-derives wrong URLs for
these. Add an HCP_API_URLS override map in oclogin-all so
resolve_api_url() and login_cluster() use the correct endpoints.

Signed-off-by: Subrata Modak <smodak@redhat.com>
Assisted-by: ClaudeAI
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jhutar
jhutar merged commit d192ae8 into konflux-ci:main Aug 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants