Skip to content

feat: Add kflux-stg-es01 to loadtest probe dashboards - #95

Closed
smodak-rh wants to merge 2 commits into
konflux-ci:mainfrom
smodak-rh:feat/add-kflux-stg-es01-loadtest-probe-dashboards
Closed

feat: Add kflux-stg-es01 to loadtest probe dashboards#95
smodak-rh wants to merge 2 commits into
konflux-ci:mainfrom
smodak-rh:feat/add-kflux-stg-es01-loadtest-probe-dashboards

Conversation

@smodak-rh

@smodak-rh smodak-rh commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

KONFLUX-15430: add the kflux-stg-es01 staging API to the Grafana cluster dropdown (loadtest probe + multiarch). kflux-prd-es01 is not included yet.

The dropdown will be empty for this cluster until Horreum test 372 has data.

Related:

Test plan

  • memberClusters includes https://api.kflux-stg-es01.21tc.p1.openshiftapps.com:6443/ in both jsonnet sources
  • Regenerated loadtest-probe.json and loadtest-probe-multiarch.json include the same API in the cluster variable
  • After merge, redeploy dashboards and confirm the cluster appears in the Grafana dropdown
  • Panels populate once Horreum 372 data exists for this cluster

Made with Cursor

Expose the staging API in the Grafana cluster dropdown for
KONFLUX-15430. Panels stay empty until Horreum data exists.
kflux-prd-es01 is deferred.

Signed-off-by: Subrata Modak <smodak@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@qodo-app-for-konflux-ci

Copy link
Copy Markdown

PR Summary by Qodo

Add kflux-stg-es01 to loadtest probe Grafana cluster dropdown

✨ Enhancement ⚙️ Configuration changes 🕐 10-20 Minutes

Grey Divider

AI Description

• Add kflux-stg-es01 API to loadtest probe cluster dropdown options.
• Update both single-arch and multiarch jsonnet sources for memberClusters.
• Regenerate Grafana dashboard JSON so the new cluster appears in variables.
Diagram

graph TD
  A["loadtest-probe.jsonnet"] --> C["memberClusters list"] --> D(["Grafana dashboard variable"])
  B["loadtest-probe-multiarch.jsonnet"] --> C --> D --> E["generated/loadtest-probe.json"]
  D --> F["generated/loadtest-probe-multiarch.json"]
  C --> G["kflux-stg-es01 API"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Centralize cluster list in a shared jsonnet library
  • ➕ Eliminates duplication between loadtest-probe and multiarch sources
  • ➕ Reduces risk of dashboards drifting out of sync
  • ➖ Requires refactoring imports and updating generation workflow
  • ➖ Slightly larger change than necessary for a single new cluster
2. Source clusters from an external config (ConfigMap/app-interface) at generation time
  • ➕ Single source of truth for environments/clusters
  • ➕ Cluster additions don’t require dashboard code changes
  • ➖ Introduces a new dependency into the generation pipeline
  • ➖ Adds operational complexity and potential for generation failures

Recommendation: Current approach is appropriate for KONFLUX-15430: add the cluster to both jsonnet sources and regenerate dashboards. If more clusters are expected soon, consider a shared jsonnet cluster list to prevent ongoing duplication and drift.

Files changed (4) +14 / -2

Enhancement (2) +2 / -0
loadtest-probe.jsonnetAdd kflux-stg-es01 to memberClusters (loadtest-probe) +1/-0

Add kflux-stg-es01 to memberClusters (loadtest-probe)

• Adds the kflux-stg-es01 staging API endpoint to the memberClusters list used to populate the Grafana cluster dropdown.

grafonnet-workdir/src/loadtest-probe.jsonnet

loadtest-probe-multiarch.jsonnetAdd kflux-stg-es01 to memberClusters (multiarch) +1/-0

Add kflux-stg-es01 to memberClusters (multiarch)

• Adds the kflux-stg-es01 staging API endpoint to the multiarch dashboard's memberClusters list so it appears in the same cluster variable dropdown.

grafonnet-workdir/src/loadtest-probe-multiarch.jsonnet

Other (2) +12 / -2
loadtest-probe.jsonRegenerate loadtest-probe dashboard JSON with new cluster option +6/-1

Regenerate loadtest-probe dashboard JSON with new cluster option

• Updates the generated dashboard variable options and query string to include the kflux-stg-es01 API endpoint in the cluster dropdown.

grafonnet-workdir/generated/loadtest-probe.json

loadtest-probe-multiarch.jsonRegenerate multiarch dashboard JSON with new cluster option +6/-1

Regenerate multiarch dashboard JSON with new cluster option

• Updates the generated multiarch dashboard variable options and query string to include the kflux-stg-es01 API endpoint in the cluster dropdown.

grafonnet-workdir/generated/loadtest-probe-multiarch.json

@qodo-app-for-konflux-ci

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can commit Qodo's fix in one click with committable suggestions (GitHub & GitLab)

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@jhutar jhutar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add to grafonnet-workdir/src/trending-errors.jsonnet

Jan requested this on konflux-ci#95 so the cluster
appears on all loadtest probe Grafana dropdowns.

Signed-off-by: Subrata Modak <smodak@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@smodak-rh

Copy link
Copy Markdown
Contributor Author

Added kflux-stg-es01 to grafonnet-workdir/src/trending-errors.jsonnet and regenerated the JSON. Ready for another look.

}
},
"pluginVersion": "v13.0.0",
"pluginVersion": "v11.4.0",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and do jb update in Grafonnet dir - these version downgrades are because you have old Jsonnet lib dependencies.

@smodak-rh

Copy link
Copy Markdown
Contributor Author

Closing without merge. KONFLUX-15430 is being dropped: kflux-stg-es01 and kflux-prd-es01 are not Konflux member clusters (they host ephemeral namespaces / Hypershift for namespace provisioning), so the normal loadtest probe does not apply. Faisal confirmed we should drop this request.

@smodak-rh smodak-rh closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants