Skip to content

FIX BUG: DECODING DATE VECTOR WITH NA VALUE THROWS EXCEPTION#64

Open
Yusuf90 wants to merge 1 commit into
konne:masterfrom
Yusuf90:hotfix/dates-NA
Open

FIX BUG: DECODING DATE VECTOR WITH NA VALUE THROWS EXCEPTION#64
Yusuf90 wants to merge 1 commit into
konne:masterfrom
Yusuf90:hotfix/dates-NA

Conversation

@Yusuf90

@Yusuf90 Yusuf90 commented May 22, 2019

Copy link
Copy Markdown
  • Add a special NA value in SexpArrayDate.cs, which is DateTime.MaxValue
  • Correctly catch NaN doubles and convert it to SexpArrayInt.Na in Qap1.cs
  • Add a test in SexpArrayDateTest.cs for decoding date vector with NA value(s) SexpArrayDate doesn't handle NAs well #8

* Add a special NA value in SexpArrayDate.cs, which is DateTime.MaxValue
* Correctly catch NaN doubles and convert it to SexpArrayInt.Na in Qap1.cs
* Add a test in SexpArrayDateTest.cs for decoding date vector with na value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant