homework #40
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,93 @@ | ||
| | ||
| using NUnit.Framework; | ||
| using NUnit.Framework.Legacy; | ||
| using FluentAssertions; | ||
|
|
||
| namespace HomeExercise.Tasks.NumberValidator; | ||
|
|
||
| [TestFixture] | ||
| public class NumberValidatorTests | ||
| { | ||
| // тут решил добавить проверку на текст с ошибкой потому что иначе если первое верно срабатывала вторая проверка падала и | ||
| // получалось неверно и непонятно что упало | ||
| // например precision 1 и scale 1 и тест первый ниже проходит хотя должен не проходить | ||
|
|
||
| [TestCase(-1, 2, "precision must be a positive number", | ||
This comment was marked as resolved.
Sorry, something went wrong. |
||
| TestName = "precision не может быть отрицательным")] | ||
| [TestCase(0, 2, "precision must be a positive number", | ||
| TestName = "precision не может быть равен 0")] | ||
| public void Constructor_WhenInvalidPrecisionProvided_ShouldThrow(int precision, int scale, string expectedMessage) | ||
| { | ||
| Action act = () => new NumberValidator(precision, scale, true); | ||
| act | ||
| .Should() | ||
| .Throw<ArgumentException>() | ||
| .WithMessage(expectedMessage | ||
| ); | ||
| } | ||
|
|
||
|
|
||
| [TestCase(1, 2, "precision must be a non-negative number less or equal than precision", | ||
This comment was marked as resolved.
Sorry, something went wrong.
Author
There was a problem hiding this comment. Тут не понял, вроде везде на русском ток поля там на английском, а тут |
||
| TestName = "scale не может быть больше precision")] | ||
| [TestCase(1, 1, "precision must be a non-negative number less or equal than precision", | ||
| TestName = "scale не может быть равен precision")] | ||
| [TestCase(1, -1, "precision must be a non-negative number less or equal than precision", | ||
| TestName = "scale не может быть отрицательным")] | ||
| public void Constructor_WhenInvalidScaleProvided_ShouldThrow(int precision, int scale, string expectedMessage) | ||
| { | ||
| Action act = () => new NumberValidator(precision, scale, true); | ||
|
|
||
| act | ||
| .Should() | ||
| .Throw<ArgumentException>() | ||
| .WithMessage(expectedMessage | ||
| ); | ||
| } | ||
|
|
||
|
|
||
| [TestCase(1, 0, TestName = "scale может быть равен 0")] | ||
| [TestCase(7, 5, TestName = "Тест на создание объекта с правильными параметрами")] | ||
| public void Constructor_WhenValidParametersProvided_ShouldNotThrow(int precision, int scale) | ||
| { | ||
| Action act = () => new NumberValidator(precision, scale, true); | ||
|
|
||
| act | ||
| .Should() | ||
| .NotThrow<Exception>( | ||
| $"Не должно быть исключения при создании NumberValidator с precision={precision}, scale={scale}"); | ||
| } | ||
|
|
||
| [TestCase(6, 2, false, "-1.23", true, TestName = "Валидное отрицательное число")] | ||
| [TestCase(6, 2, true, "+1.23", true, TestName = "Валидное положительное число")] | ||
| [TestCase(1, 0, true, "0", true, TestName = "Валидное целое число")] | ||
| [TestCase(4, 2, true, "+1.23", true, TestName = "Валидное число где знак и цифры укладываются в precision")] | ||
| [TestCase(6, 2, true, "+1,23", true, TestName = "Валидное число через запятую")] | ||
| public void IsValidNumber_WhenValidInputProvided_ShouldReturnTrue(int precision, int scale, bool onlyPositive, string input, bool expectedResult) | ||
| { | ||
| var validator = new NumberValidator(precision, scale, onlyPositive); | ||
| var result = validator.IsValidNumber(input); | ||
|
|
||
| result | ||
| .Should() | ||
| .BeTrue( | ||
| $"Ожидалось, что '{input}' будет валидным при precision={precision}, scale={scale}, onlyPositive={onlyPositive}" | ||
| ); | ||
| } | ||
|
|
||
| [TestCase(3, 2, true, "00.00", false, TestName = "Ошибка: вышло за пределы precision")] | ||
| [TestCase(4, 2, true, "-0.00", false, TestName = "Ошибка: отрицательное число при onlyPositive=true")] | ||
| [TestCase(3, 2, true, "+0.00", false, TestName = "Ошибка: превышена точность из-за знака")] | ||
| [TestCase(6, 2, true, "0.000", false, TestName = "Ошибка: дробная часть превышает scale")] | ||
| [TestCase(3, 2, true, "a.sd", false, TestName = "Ошибка: нечисловая строка")] | ||
| public void IsValidNumber_WhenInvalidInputProvided_ShouldReturnFalse(int precision, int scale, bool onlyPositive, string input, bool expectedResult) | ||
| { | ||
| var validator = new NumberValidator(precision, scale, onlyPositive); | ||
| var result = validator.IsValidNumber(input); | ||
|
|
||
| result | ||
| .Should() | ||
| .BeFalse( | ||
| $"Ожидалось, что '{input}' будет невалидным при precision={precision}, scale={scale}, onlyPositive={onlyPositive}" | ||
| ); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А можно ли как-то учитывать только поле Id?
И можно ли написать этот тест так, чтобы при переименовании Id на например Identificator тест все-равно работал правильно?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Через .Including можно выбрать поля которые мы хоти сравнивать и сравнивать только их
На второй вопрос не знаю как сделать, чтобы при переименовании тест все равно понимал, что исключать, но к id обращаться через аксессор get, и тогда сразу должна выпасть ошибка и мы поймем что он не нашел поле id, но вообще если именование правильное зачем его менять в будущем?