Update task_manager.py#733
Conversation
fixes: konveyor#722 1. Check you have corrected Java version 2. IsADirectoryError separately handeled. Signed-off-by: Rohan Mishra <315scisyb2020rohanmishra@gmail.com>
There was a problem hiding this comment.
Thank you for attempting a fix for this. Really appreciate it. A few suggestions...It would be better to fix this issue at the root instead of catching it as an exception. What is happening is that something that is not an error is being parsed as an OtherError with a wrong file path. The correct place to fix this would be in file https://github.com/konveyor/kai/blob/main/kai/reactive_codeplanner/task_runner/compiler/maven_validator.py
This is where we run the maven command and parse its output. To understand how we are parsing the errors, take a look at this function
kai/kai/reactive_codeplanner/task_runner/compiler/maven_validator.py
Lines 594 to 623 in 725cd68
Most probably the fix will be in this function (you may have to reproduce the issue to figure that out). To reproduce, you can simply create a new test in file https://github.com/konveyor/kai/blob/main/tests/test_maven_validator.py
Use the output in the issue description. Take a look at existing tests to figure out how the parse_error_lines function is called. And finally, reach out if you need help :)
Thank you again.
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. |
fixes: #722