feat: add Name to the human readable output of the list command#28
feat: add Name to the human readable output of the list command#28feloy merged 2 commits intokortex-hub:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded a single line to workspace list output to print each workspace's "Name" (using instance.GetName()), and expanded tests to assert the presence of ID, Name, Sources, and Configuration substrings in various listing scenarios including JSON paths and aliases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkg/cmd/workspace_list_test.go`:
- Around line 126-128: The test currently asserts the raw name via
addedInstance.GetName(), which can pass even if the formatted "Name:" line
regresses; update the assertions to check the labeled formatted output (e.g.
assert that the output contains " Name: "+addedInstance.GetName()) instead of
just the raw name, and apply the same change to the other related assertions
that verify multi-workspace and alias-path output so they validate the exact
"Name:" and alias/path labeled lines coming from manager.List().
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 882dcc51-552d-40db-9f2f-05fb01edc5bc
📒 Files selected for processing (2)
pkg/cmd/workspace_list.gopkg/cmd/workspace_list_test.go
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com> Co-Authored-By: Claude Code (Claude Sonnet 4.5) <noreply@anthropic.com>
Adds the Name to the human-readable output of the
workspace listcommand