-
Notifications
You must be signed in to change notification settings - Fork 2
feat: stop command #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
feloy
wants to merge
1
commit into
kortex-hub:main
Choose a base branch
from
feloy:stop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+509
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /********************************************************************** | ||
| * Copyright (C) 2026 Red Hat, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| **********************************************************************/ | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func NewStopCmd() *cobra.Command { | ||
| // Create the workspace stop command | ||
| workspaceStopCmd := NewWorkspaceStopCmd() | ||
|
|
||
| // Create an alias command that delegates to workspace stop | ||
| cmd := &cobra.Command{ | ||
| Use: "stop ID", | ||
| Short: workspaceStopCmd.Short, | ||
| Long: workspaceStopCmd.Long, | ||
| Args: workspaceStopCmd.Args, | ||
| PreRunE: workspaceStopCmd.PreRunE, | ||
| RunE: workspaceStopCmd.RunE, | ||
| } | ||
|
|
||
| // Copy flags from workspace stop command | ||
| cmd.Flags().AddFlagSet(workspaceStopCmd.Flags()) | ||
|
|
||
| return cmd | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| /********************************************************************** | ||
| * Copyright (C) 2026 Red Hat, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| **********************************************************************/ | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestStopCmd(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| cmd := NewStopCmd() | ||
| if cmd == nil { | ||
| t.Fatal("NewStopCmd() returned nil") | ||
| } | ||
|
|
||
| if cmd.Use != "stop ID" { | ||
| t.Errorf("Expected Use to be 'stop ID', got '%s'", cmd.Use) | ||
| } | ||
|
|
||
| // Verify it has the same behavior as workspace stop | ||
| workspaceStopCmd := NewWorkspaceStopCmd() | ||
| if cmd.Short != workspaceStopCmd.Short { | ||
| t.Errorf("Expected Short to match workspace stop, got '%s'", cmd.Short) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /********************************************************************** | ||
| * Copyright (C) 2026 Red Hat, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| **********************************************************************/ | ||
|
|
||
| package cmd | ||
|
|
||
| import ( | ||
| "errors" | ||
| "fmt" | ||
|
|
||
| "github.com/kortex-hub/kortex-cli/pkg/instances" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| // workspaceStopCmd contains the configuration for the workspace stop command | ||
| type workspaceStopCmd struct { | ||
| manager instances.Manager | ||
| id string | ||
| } | ||
|
|
||
| // preRun validates the parameters and flags | ||
| func (w *workspaceStopCmd) preRun(cmd *cobra.Command, args []string) error { | ||
| w.id = args[0] | ||
|
|
||
| // Get storage directory from global flag | ||
| storageDir, err := cmd.Flags().GetString("storage") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to read --storage flag: %w", err) | ||
| } | ||
|
|
||
| // Create manager | ||
| manager, err := instances.NewManager(storageDir) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create manager: %w", err) | ||
| } | ||
| w.manager = manager | ||
feloy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // run executes the workspace stop command logic | ||
| func (w *workspaceStopCmd) run(cmd *cobra.Command, args []string) error { | ||
| // Delete the instance | ||
| err := w.manager.Delete(w.id) | ||
| if err != nil { | ||
| if errors.Is(err, instances.ErrInstanceNotFound) { | ||
| return fmt.Errorf("workspace not found: %s\nUse 'workspace list' to see available workspaces", w.id) | ||
| } | ||
| return fmt.Errorf("failed to stop workspace: %w", err) | ||
feloy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| // Output only the ID | ||
| cmd.Println(w.id) | ||
| return nil | ||
| } | ||
|
|
||
| func NewWorkspaceStopCmd() *cobra.Command { | ||
| c := &workspaceStopCmd{} | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "stop ID", | ||
| Short: "Stop a workspace", | ||
| Long: "Stop a workspace by its ID", | ||
| Args: cobra.ExactArgs(1), | ||
| PreRunE: c.preRun, | ||
| RunE: c.run, | ||
| } | ||
|
|
||
| return cmd | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.