Skip to content

fix: pass absolute storage path to manager#39

Merged
feloy merged 1 commit intokortex-hub:mainfrom
feloy:normalize-storage-path
Mar 10, 2026
Merged

fix: pass absolute storage path to manager#39
feloy merged 1 commit intokortex-hub:mainfrom
feloy:normalize-storage-path

Conversation

@feloy
Copy link
Contributor

@feloy feloy commented Mar 9, 2026

fixes #29

@coderabbitai
Copy link

coderabbitai bot commented Mar 9, 2026

Warning

Rate limit exceeded

@feloy has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 16 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f84c45c3-3982-42f3-a0ae-3f9f3f248ab1

📥 Commits

Reviewing files that changed from the base of the PR and between 5635b65 and 50b3f02.

📒 Files selected for processing (2)
  • pkg/cmd/init.go
  • pkg/cmd/workspace_list.go
📝 Walkthrough

Walkthrough

The changes normalize the --storage flag to absolute paths in command preRun methods using filepath.Abs() before passing to instances.NewManager(). This ensures deterministic behavior regardless of the caller's working directory, with error handling for path resolution failures.

Changes

Cohort / File(s) Summary
Storage Path Normalization
pkg/cmd/init.go, pkg/cmd/workspace_list.go
Import path/filepath and convert storageDir flag to absolute path using filepath.Abs(). Handle errors if resolution fails and pass absolute path to instances.NewManager().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: pass absolute storage path to manager' clearly and concisely describes the main change in the PR, which is to normalize relative storage paths to absolute paths before passing them to the manager.
Description check ✅ Passed The description 'fixes #29' is related to the changeset, as the PR is indeed addressing issue #29 which requests normalizing the storage path to absolute.
Linked Issues check ✅ Passed The code changes in both files implement the suggested fix from issue #29 by calling filepath.Abs() on storageDir and handling errors appropriately before passing to the manager.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the linked issue #29: adding filepath imports and converting storage paths to absolute in preRun methods of workspace commands.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@feloy feloy requested review from benoitf and jeffmaury March 9, 2026 17:55
Signed-off-by: Philippe Martin <phmartin@redhat.com>
@feloy feloy force-pushed the normalize-storage-path branch from 5635b65 to 50b3f02 Compare March 9, 2026 17:55
@feloy feloy merged commit 7e67e4b into kortex-hub:main Mar 10, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: normalize --storage flag to absolute path in preRun

2 participants