web: Fix keyboard controls on non-QWERTY layouts#13
Open
Scotsguy wants to merge 1 commit intokoute:masterfrom
Open
web: Fix keyboard controls on non-QWERTY layouts#13Scotsguy wants to merge 1 commit intokoute:masterfrom
Scotsguy wants to merge 1 commit intokoute:masterfrom
Conversation
Using the keycode instead of the actual key it corresponds to means that the selected keyboard layout is irrelevant, only the location.
Scotsguy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of binding controls to
zandyetc., this PR binds them to the location of those keys.I cannot test the Edge quirks, so I just left them there. Let's hope Edge has correct Keycodes, at least.