feat(arc-vue): export built CSS so consumers get styles - #20
Open
sousuke0422 wants to merge 1 commit into
Open
Conversation
Add ./style.css export, CSS sideEffects, consumer-pack test, and CI test step. #10 release.yml publish automation deferred per shogun directive. Assisted-by: multi-agent-shogun-aki-tweak
|
Tip All tests passed and all changes approved!🟢 UI Tests: 5 tests unchanged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
リポジトリ監査の指摘（arc-vue が build 済み CSS を export せず
sideEffects: falseのため、消費側でスクロール・絶対配置・仮想化の寸法などが欠落する）を修正する。これにより task #341（Gantt ビュー）等の消費側が arc-vue のスタイルを正しく取り込める。
変更内容
packages/arc-vue/package.jsonのexportsに"./style.css": "./dist/arc-vue.css"を追加。消費側はimport '@koyori-app/arc-vue/style.css'でスタイルを取り込める。sideEffectsをfalse→["**/*.css"]に変更。バンドラが CSS の副作用 import を落とさないようにする。npm packした tarball を別ディレクトリで install し、./style.csssubpath が解決できることを検証するテスト（consumerPack.test.ts）を追加。ci.ymlの vue ジョブにpnpm test（packages/arc-vue）ステップを追加し、上記テストを CI で回す。スコープ外
release への arc-vue publish 追加（#10）は本 PR では扱わない。core も含め npm Trusted Publisher が未登録で、publish パイプラインの拡張は資格情報の整備後とする（殿裁定「既にある準備以上は追わない」）。
※ DRAFT 解除・merge は maintainer 判断。
Assisted-by: multi-agent-shogun-aki-tweak