test(cli): add vitest test foundation for apps/cli - #353
Merged
Conversation
Assisted-by: multi-agent-shogun-aki-tweak
|
前回のレビューから新たな問題は見つかりませんでした。 全テストファイル(6ファイル・23テスト)をソースコードと突き合わせて確認しましたが、以下の点はすべて適切です:
|
Assisted-by: multi-agent-shogun-aki-tweak
Deploying koyori with
|
| Latest commit: |
60238b7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0b4540e0.koyori.pages.dev |
| Branch Preview URL: | https://test-cli-vitest-foundation.koyori.pages.dev |
Assisted-by: multi-agent-shogun-aki-tweak
sousuke0422
marked this pull request as ready for review
July 15, 2026 09:59
|
前回のレビューで「全テストファイル・23テストをソースコードと突き合わせて確認し、問題なし」と判断済みです。 前回のレビューから新たな問題は見つかりませんでした。 |
Add tsconfig.test.json (noEmit, includes __tests__) and run tsc in cli-test.yml so expectTypeOf contract tests fail CI on type mismatch. Assisted-by: multi-agent-shogun-aki-tweak
Add paths.test.ts comment that CI typecheck:test enforces expectTypeOf contracts; globalSetup builds dist when missing; relax os mock tmpdir hardcoding and entry stderr strict match. Assisted-by: multi-agent-shogun-aki-tweak
Compare src/tsconfig mtimes against dist before skipping the vitest build step so direct vitest runs cannot pass against stale compiled output. Rename entry it.each titles to match --help rendering behavior. Assisted-by: multi-agent-shogun-aki-tweak
yupix
approved these changes
Jul 15, 2026
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


概要
apps/cli(@koyori/task-cli・6 コマンド: auth/config/my/projects/sprints/tasks)に vitest テスト基盤を導入し、CI で実走させる。現状の正しい挙動をゴールデン固定する安全網。#237(ESM 移行)・#235(commander v15)の前提工事。スコープ
.github/workflows/cli-test.yml・pull_request/push(main))。チェックリスト
testscript 追加config/store(一時ディレクトリ・実ファイル破壊なし)api/paths・api/client(openapi-fetch モック)utils(output/errors/projects/statuses/command)ユニットbin/task.js→index.ts)起動 smokecli-test.yml新設(pull_request で回る・40桁 SHA ピン留め)29406072277success・本 PR の主眼=偽緑排除を達成)コミット
f8dfccd1— cli-test.yml 新設(pull_request/push(main)・40桁 SHA 固定)25fb4747— pnpm version の明示 pin(CI 緑化)Closes #352
Assisted-by: multi-agent-shogun-aki-tweak