Feature/sklearn method pluggin#31
Merged
kparasch merged 5 commits intokparasch:developfrom Mar 30, 2026
Merged
Conversation
kparasch
requested changes
Mar 30, 2026
Owner
kparasch
left a comment
There was a problem hiding this comment.
I like the idea! I made some comments where we can simplify a bit.
Also could you rebase to the develop branch and remove commit d47440c which is related to the other PR?
240c4bd to
e30fd59
Compare
9a59ce0 to
56cc089
Compare
Owner
|
I just merged some workflows to run both pySC and pyAML tests that are related to pySC. I will merge them also to this PR to make sure pyaml doesn't break, and then do the final merge. |
workflow for tests, including testing for pyAML (related to pySC)
Author
|
Great, nice to have tests! I'll be doing next PRs with develop as origin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for sklearn-like method passing to injection/orbit correction
Custom solver protocol:
Example with sklearn (should match parameter=100.0)