fix: bump kubernetes fork to fix WatchList multicluster LIST empty bug#17
Merged
zachsmith1 merged 1 commit intomainfrom Apr 4, 2026
Merged
Conversation
The reflector's WatchList temporary store keyed objects by namespace/name, causing objects from different clusters with the same name (e.g., every VCP has a "default" namespace) to overwrite each other. After apiserver restart, LIST returned empty results for all but the last cluster. Bumps kplane-dev/kubernetes, kplane-dev/storage, and kplane-dev/informer to pick up the fix that adds WatchListKeyFunc to the reflector, allowing the cacher to use a cluster-aware key function for the temporary store. Adds TestListAfterRestart smoke test that reproduces the bug (create multiple VCPs, restart apiserver, verify LIST still works).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps kplane-dev/kubernetes, kplane-dev/storage, and kplane-dev/informer to pick up the fix for the WatchList multicluster LIST empty bug.
Problem
After apiserver restart, LIST returned empty results for all but one VCP. The reflector's WatchList temporary store keyed objects by namespace/name, causing objects from different clusters with the same name to overwrite each other.
Fix
kplane-dev/kubernetes#2 adds
WatchListKeyFuncto the reflector. The cacher sets it to the cluster-aware key function when identity hooks are configured.Test plan
TestListAfterRestartsmoke test — creates 3 VCPs, restarts apiserver, verifies LIST still works for all VCPs