Modernize Rubocop#166
Merged
Merged
Conversation
johnnyshields
force-pushed
the
modernize-rubocop
branch
from
7b88ccb to
f53037c
Compare
- Add Github Actions CI, ensure support for latest Ruby and Rails - Remove cruft: .travis.yml, .codeclimate.yml, .hound.yml - Remove appraisal gem, use RAILS_VERSION env var in main Gemfile instead. - Drop support for Ruby prior to 2.7--2.7 is already 5+ years EOL - Remove UPGRADING message as it's very old. - Move add_development_dependency to Gemfile, as per latest recommendations - Fix issues with Rails deprecation silencing in tests
- Switch Rubocop to use modern conventions - Create .rubocop_todo.yml - Add a few simple cleanups
johnnyshields
force-pushed
the
modernize-rubocop
branch
from
a7ba147 to
c68b941
Compare
ssinghi
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based off of #165, please merge that one first.
Rubocop in this project was extremely strange, it was not applying to many files, and had a very long list of customized cops that look like they were generated as boilerplate long ago.
I've redone the .rubocop.yml file to have minimal, sensible defaults, and I've created .rubocop_todo.yml using
rubocop --auto-gen-config --exclude-limit 1000. This will allow gradual migration use the modern Rubocop standards across the project; many can be automatically done withrubocop -A.