Harden core app stability and offline media flow - #24
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb09f1f026
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| BackupService({ConnectivityService? connectivityService}) | ||
| : _connectivityService = connectivityService ?? ConnectivityService(); |
There was a problem hiding this comment.
Keep BackupService constructible at existing call sites
Changing BackupService to a non-const constructor breaks the existing const BackupService() field initializer in lib/features/account/screen/account_screen.dart, so the app will no longer compile whenever that screen is analyzed/built. Either update that call site to drop const or preserve a const-compatible constructor path.
Useful? React with 👍 / 👎.
Motivation
Description
ErrorReporterthat initializes Firebase Crashlytics and wiresFlutterError.onError,PlatformDispatcher.instance.onError, and zoned error capture inmain.dart.ImageCompressionServiceto compress camera captures before overlay generation and lower final JPEG quality inImageOverlayService.ConnectivityServiceand an enhancedBackupServicethat persists a retry queue, exposesuploadPhotosForUser, and starts auto-retry on reconnect; queueing is invoked after a successful local save in the result flow.ErrorReporter, and switch gallery grid thumbnails to resized decoding (cacheWidth) for lower memory and faster loads.CachedNetworkImageand making Google static map fetches go through aBaseCacheManagerfallback; add related dependencies inpubspec.yaml.Testing
git diff --checkto validate diffs and whitespace issues (passed with no errors).flutter pub getbut it failed in this environment because the Flutter SDK is not available (flutter: command not found), so dependency resolution and package-level build/tests were not executed here.flutter pub get, thenflutter analyzeandflutter teston a machine with the SDK).Codex Task