Improve camera preview scaling, overlay templates, and gallery/locations UI - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_CameraPreviewCoverand use of the controllerpreviewSizewithFittedBox(fit: BoxFit.cover)so the preview fills the viewport exactly without changingCameraControllerinitialization; changes inlib/features/camera/screen/camera_screen.dart.overlayTemplatetoAppSettingsandSettingsService, implemented a Templates bottom sheet (_showTemplateSheetand_TemplateChoiceTile) and removed the bottom-bar Settings entry inlib/features/camera/screen/camera_screen.dartandlib/models/app_settings.dart/lib/services/settings_service.dart.LocationStampCardto support three templates, improved typography, spacing, contrast, compact preview, and map thumbnail clipping inlib/core/widgets/location_stamp_card.dart, and madeImageOverlayServiceapply the selected template when composing burned-in images and added rendering code forminimal_stripandfield_reportinlib/services/image_overlay_service.dart.lib/features/locations/screen/locations_screen.dart.Sliversections, tighter 3-column grid, thumbnail overlays, selection mode with share/delete, and a swipeable/pinch-zoom full-screen viewer with share/info/delete controls inlib/features/gallery/screen/gallery_screen.dart.lib/features/result/screen/result_screen.dartandlib/services/image_overlay_service.dart.Files changed (high level):
lib/features/camera/screen/camera_screen.dart,lib/core/widgets/location_stamp_card.dart,lib/services/image_overlay_service.dart,lib/models/app_settings.dart,lib/services/settings_service.dart,lib/features/locations/screen/locations_screen.dart,lib/features/gallery/screen/gallery_screen.dart,lib/features/result/screen/result_screen.dart.Testing
git diff --checkto verify there are no whitespace/indexing issues and it passed.dart formatandflutter analyze(dart format ... && flutter analyze) but the environment does not havedart/flutterinstalled so automatic formatting and static analysis could not be executed.flutter testbut the environment does not haveflutterinstalled so unit/widget tests could not be executed here.Codex Task