Logs from etgar#48
Open
krleonid wants to merge 4 commits into
Open
Conversation
…ed > 1s Logs via DUCKDB_LOG_WARNING with queue_size and dead_nodes count. Also prints to stderr in DEBUG builds for local debugging. Requires: SET GLOBAL enable_logging = true; SET GLOBAL logging_level = 'warning'; Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Defer re-enqueue of alive nodes until after the purge loop completes. Previously, enqueue_bulk fed alive nodes back into the purge thread's own sub-queue between iterations, causing try_dequeue_bulk to re-drain those same alive nodes instead of reaching dead entries in worker thread sub-queues. Also add stderr print for purge warnings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add IsDeadNode() to correctly identify dead nodes (expired weak_ptr or sequence mismatch) without conflating pinned-but-alive nodes as dead - Use IsDeadNode() in PurgeIteration instead of TryGetBlockMemory() which incorrectly counted pinned nodes as dead - Remove GetBuffer() guard in BlockMemory destructor so IncrementDeadNodes fires for blocks destroyed after eviction (buffer already null) - Add total_dequeued breakdown (alive/dead) to Purge warning log Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.