Fixed broken link and HTML changes - #4
Open
louisjunker wants to merge 4 commits into
Open
Conversation
…that 1.000 hits, since no period or decimal existed for replacement
…that 1.000 hits, since no period or decimal existed for replacement
…webpage structure of boliga.dk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boliga.dk has changed several things on their page.
First they have changed the option of choosing exact date to look up houses old. It only supports year now.
They have also changed some of the structure of their HTML coding. This has been updated.
I have added a column to the final output containing salgstype ("Alm Salg", "Familiesalg", etc.). This was named boligtype before.
I added boligtype ("Villa", "Landejendom", etc.).
I also made a more robust solution to my earlier contribution where number of results now reads correctly.
The solution should work now for boliga_webscrape_sold.R.
Attention
The funciton for all (boliga_all_houses.R) is not working.
Updates needed for:
There might be more, but I am unsure whether the function is for all sold houses, or all houses for sale.