Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/cli/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func Run(args []string, stdout, stderr io.Writer) int {
return 130
}

fmt.Fprintln(stderr, err)
_, _ = fmt.Fprintln(stderr, err)
if isUsageError(err) {
return 2
}
Expand All @@ -62,8 +62,8 @@ func newRootCmd() *cobra.Command {

root.RunE = func(cmd *cobra.Command, args []string) error {
if v, _ := cmd.Flags().GetBool("version"); v {
fmt.Fprintln(cmd.OutOrStdout(), versionString())
return nil
_, err := fmt.Fprintln(cmd.OutOrStdout(), versionString())
return err
}
return pickRunE(cmd, nil)
}
Expand Down
4 changes: 2 additions & 2 deletions internal/cli/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ func newInitCmd() *cobra.Command {
if err != nil {
return newUsageError(err)
}
fmt.Fprint(cmd.OutOrStdout(), script)
return nil
_, err = fmt.Fprint(cmd.OutOrStdout(), script)
return err
},
}
}
Expand Down
6 changes: 4 additions & 2 deletions internal/cli/pick.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,11 @@ func pickRunE(cmd *cobra.Command, args []string) error {
}

out := cmd.OutOrStdout()
fmt.Fprintln(out, abs)
if _, err := fmt.Fprintln(out, abs); err != nil {
return err
}
if isTerminal(out) {
fmt.Fprintln(cmd.ErrOrStderr(), initHint)
_, _ = fmt.Fprintln(cmd.ErrOrStderr(), initHint)
}
return nil
}
4 changes: 2 additions & 2 deletions internal/cli/scan.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ func newScanCmd() *cobra.Command {
return err
}

fmt.Fprintf(cmd.OutOrStdout(), "Seeded %d Visits across %d Projects\n", summary.Seeded, summary.Projects)
return nil
_, err = fmt.Fprintf(cmd.OutOrStdout(), "Seeded %d Visits across %d Projects\n", summary.Seeded, summary.Projects)
return err
},
}
}
4 changes: 2 additions & 2 deletions internal/cli/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ func newVersionCmd() *cobra.Command {
Short: "print the cdd version",
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, _ []string) error {
fmt.Fprintln(cmd.OutOrStdout(), versionString())
return nil
_, err := fmt.Fprintln(cmd.OutOrStdout(), versionString())
return err
},
}
}
Expand Down
2 changes: 1 addition & 1 deletion internal/picker/model_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func TestModel_FuzzyFilter(t *testing.T) {
next, _ := m.Update(tea.WindowSizeMsg{Width: 120, Height: 40})
m = next.(picker.Model)

for _, r := range []rune("billing") {
for _, r := range "billing" {
next, _ = m.Update(tea.KeyPressMsg{Text: string(r)})
m = next.(picker.Model)
}
Expand Down