fix: Picker frame was one line taller than the terminal, hiding the filter line - #50
Merged
Merged
Conversation
… stays visible The preview column was one line taller than the list, so every frame was one line taller than the terminal. Bubble Tea's inline renderer dropped the top line, the filter line, and repainted every tick. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…thout the preview Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On every terminal size the rendered frame was one line taller than the terminal. Bubble Tea's inline renderer drops the top line in that case, which is the filter line, and repaints the whole frame on every tick (686 KB of output in two seconds, now 7 KB).
Cause: the preview column carried a leading blank line above a box that is already
ListHeighttall, and the box could also grow pastListHeightwhen its body was taller, since lipglossHeightis a minimum.fix(picker): join the preview box at the top of the list and cap it withMaxHeight.test(picker): the frame must be exactly the terminal height at five heights, with and without the preview.Verified through a terminal emulator against the demo environment: filter line, legend, and keys line all visible at 30 and 9 rows.
🤖 Generated with Claude Code