Fix release process and restore workflow_run trigger - #14
Merged
Conversation
…tion uv run --no-project doesn't set shell PATH to venv bin. Module invocation always works. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Tag pushes from release.yml use GITHUB_TOKEN which does NOT trigger other workflows (GitHub Actions limitation). The workflow_run trigger is required as a workaround. Tightened publish condition to only fire when Release workflow completes successfully. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the release workflow to improve reliability and ensure that publishing to PyPI only occurs after a successful release workflow. The main changes involve how the CI pipeline is triggered and how the release step is executed.
Workflow Triggering and Release Logic:
.github/workflows/CI.yml: Added aworkflow_runtrigger so that the CI workflow is now triggered when the "Release" workflow completes, rather than on tag pushes alone..github/workflows/CI.yml: Updated the release job condition to only run when the "Release" workflow completes successfully, preventing accidental or duplicate releases.Release Command Update:
.github/workflows/release.yml: Changed the release command to usepython -m semantic_release versioninstead of callingsemantic-releasedirectly, ensuring compatibility and clarity in how the release is executed.## SummaryType of Change
Checklist
type(scope): summary)ruff, formatting, stub parity)Linked Issues
Notes for Reviewer