Add Goldberg-Plotkin-Shannon synchronized (Delta + 1)-coloring algorithm#57
Open
Feq149 wants to merge 3 commits into
Open
Add Goldberg-Plotkin-Shannon synchronized (Delta + 1)-coloring algorithm#57Feq149 wants to merge 3 commits into
Feq149 wants to merge 3 commits into
Conversation
krzysztof-turowski
approved these changes
Jan 21, 2025
krzysztof-turowski
left a comment
krzysztof-turowski
left a comment
Owner
There was a problem hiding this comment.
Thank you very much, I have run the code locally - but please (1) fix the style issues (see "make format" command in Makefile for a proper command to do so), (2) provide example invocation in Makefile, (3) please add LaTeX source alongside pdf, (4) please git mv files to follow conventions:
- graphs/coloring/sync_gps/gps.go
- example/graphs_coloring_sync_gps.go (I know it's counterintuitive, but this way it agrees with directory structure)
- test/graphs_coloring_test.go
Comment on lines
+111
to
+113
| } else { | ||
|
|
||
| } |
Comment on lines
+122
to
+125
| if _,exists := s.Pseudoforests_in[s.Current_pseudoforest];!exists { | ||
| return | ||
|
|
||
| } |
There was a problem hiding this comment.
Please remove empty line, add space after comma (before exists) etc. - in general please run gofmt -l -s -w FILE` on files you created
krzysztof-turowski
changed the title
krzysztof-turowski
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.