docs(m3): land the six PR #40 review follow-ups - #41
Merged
Conversation
Nice-to-have findings from the adversarial review of PR #40, deliberately not fixed in-loop. Review record: ~/.claude/reviews/constellation/2026-08-13-fix-m3-platform-arm-on-arrival.md - F6: docs/AUTONOMY.md (playbook step 3 + the sharp edge) and /verify-planet's operating rules said the platform arms on "first contact". It arms on the first LANDING — a side clip does not arm it, which matters most on planet-3, where the ledge sits on continuous ground and walking into it never starts the countdown. As written it told a headless driver to wait for platformCount to reach 0 forever. - F2: /verify-planet step 3 still said to cast summon-platform "at the pit", contradicting its own rules 20 lines up. Mirrors AUTONOMY step 3. - F3: HANDOFF.md was dated 2026-07-26 and claimed two remaining Open BACKLOG items (now four); refreshed the date, standing, next move and recently-touched files. Decisions.md gains D9 for the drop-time → landing-time lifetime reversal. - F4: the phone's platform copy promised "holds 5s" while the lasting-platform talent makes it 8000ms. Dropped the number rather than threading the boosted flag through FEEDBACK; "he" → "they". - F7: documented the fourth placement constraint on planet-3's platformDrop — the hidden platform's collider is solid always, so the ledge can bump it — and recorded that clean clearance is unsatisfiable inside the 744..757 window F5 forces. Accepted, not solved. - F8: the "blocked, not landed" test asserted GROUND_SURFACE_Y > platformTop, looser than the runtime gate; it now asserts against PLATFORM_LANDING_EPSILON and gains an upper bound so a ledge raised above head height fails too. Gates: typecheck · typecheck:tests · vitest 207/207 · build. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YLr4UWKBbzmSaMxi1vbkdR
ksdisch
added a commit
that referenced
this pull request
Aug 13, 2026
…#42) Residue of review finding F6, in the one place F6 didn't name. PR #41 corrected AUTONOMY.md, /verify-planet, BACKLOG.md and the phone copy, but the docblock on summonPlatform() itself — directly above the function whose whole point is that it does NOT schedule the fade — still said armPlatform() starts the lifetime on the astronaut's "first contact". A side clip and an underside bonk are contacts that deliberately do not arm it; armPlatform()'s own docblock 30 lines down already says so. Also drops "ARMED BUT NOT COUNTING DOWN" from the summary line: `armed` is the sprite-data flag meaning "counting down", so that phrasing inverted the code's own vocabulary. A freshly dropped platform is unarmed. Comment-only. Gates: typecheck · typecheck:tests · vitest 207/207 · build. Claude-Session: https://claude.ai/code/session_01YLr4UWKBbzmSaMxi1vbkdR Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out the six nice-to-have findings from PR #40's adversarial review that were deliberately routed to follow-up rather than fixed in-loop. Review record:
~/.claude/reviews/constellation/2026-08-13-fix-m3-platform-arm-on-arrival.md; disposition table.docs/AUTONOMY.md(playbook step 3 + the sharp edge) and.claude/commands/verify-planet.mdsaid the platform arms on "first contact". It arms on the first landing — a side clip or underside bonk does not. Highest-value of the six: on planet-3 the ledge sits on continuous ground, so a driver following the old wording waits forplatformCountto reach 0 forever./verify-planetstep 3 still told the driver to castsummon-platform"at the pit", contradicting its own operating rules 20 lines above. Now mirrors AUTONOMY step 3.HANDOFF.mdwas dated 2026-07-26 and asserted "the two remaining BACKLOG items" (now four). Date, "Where things stand", "Immediate next move" and "Files touched recently" refreshed.Decisions.mdgains D9 for the drop-time → landing-time lifetime reversal.src/phone/App.tsx:48promised "holds 5s" while thelasting-platformtalent makes it 8000ms. Dropped the number rather than threadingboostedthroughFEEDBACK; "he" → "they". The BACKLOG Done note that quoted the old string was updated to match.platformDrop: the hidden platform's collider (x 820–940) is solid always, so the ledge can bump it. Recorded that clean clearance needsx <= 680, unsatisfiable inside the 744..757 window F5 forces — accepted, not solved, with a do-not-move-without-re-deriving note.GROUND_SURFACE_Y > platformTop, looser than the runtime gate — aplatformDrop.yof 506 would pass while arming at runtime. Now asserts againstPLATFORM_LANDING_EPSILON, plus an upper bound so a ledge raised above head height (walked under, never blocked) fails too.Gates
npm run typecheck✅ ·npm run typecheck:tests✅ ·npm run test✅ 207/207 ·npm run build✅Review-loop note
Per CLAUDE.md, the adversarial-review loop is skipped on this PR under the trivial-diff escape hatch, stated rather than silent. Five of six findings are docs-only. The two that touch code are non-behavioral: one user-facing string in
App.tsx(no logic), and tightened assertions in an existing pure-data test (no production code). No gameplay, protocol, relay, or dependency changes.🤖 Generated with Claude Code
https://claude.ai/code/session_01YLr4UWKBbzmSaMxi1vbkdR